ppkarwasz commented on code in PR #2112:
URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432444182
##########
log4j-core-test/pom.xml:
##########
@@ -371,6 +375,32 @@
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>test-disruptor-4</id>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <additionalClasspathDependencies>
+ <dependency>
+ <groupId>com.lmax</groupId>
+ <artifactId>disruptor</artifactId>
+ <version>${disruptor4.version}</version>
+ </dependency>
+ </additionalClasspathDependencies>
+ <classpathDependencyExcludes>
+
<classpathDependencyExclude>com.lmax:disruptor</classpathDependencyExclude>
+ </classpathDependencyExcludes>
+
<groups>org.apache.logging.log4j.core.test.categories.AsyncLoggers</groups>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review Comment:
Dependabot certainly can not upgrade this: `additionalClasspathDependencies`
is new in Surefire 3.2.x.
Also `dependencyManagement` won't help, since we need to compile against
version 3.x of Disruptor. Maybe we can put it in `pluginManagement` or a
profile that is never used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
