vy commented on code in PR #2120:
URL: https://github.com/apache/logging-log4j2/pull/2120#discussion_r1434052751
##########
log4j-core/pom.xml:
##########
@@ -66,15 +66,16 @@
<!-- Remove `transitive` from optional dependencies -->
com.fasterxml.jackson.annotation;transitive=false,
com.lmax.disruptor;transitive=false,
- com.fasterxml.jackson.core;substitute="jackson-core";transitive=false,
-
com.fasterxml.jackson.databind;substitute="jackson-databind";transitive=false,
-
com.fasterxml.jackson.dataformat.xml;substitute="jackson-dataformat-xml";transitive=false,
-
com.fasterxml.jackson.dataformat.yaml;substitute="jackson-dataformat-yaml";transitive=false,
+ com.fasterxml.jackson.core;transitive=false,
+ com.fasterxml.jackson.databind;transitive=false,
+ com.fasterxml.jackson.dataformat.xml;transitive=false,
+ com.fasterxml.jackson.dataformat.yaml;transitive=false,
java.naming;transitive=false,
org.apache.commons.csv;transitive=false,
org.fusesource.jansi;transitive=false,
+ <!-- Newer versions have a module descriptor -->
+
com.conversantmedia.disruptor;substitute="disruptor";transitive=false;static=true,
Review Comment:
Why `substitute` is not necessary for Jackson et al., whereas it is for
Disruptor?
##########
src/changelog/.2.x.x/simplify_configuration_after_bnd_7_update.xml:
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to you under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xmlns="http://logging.apache.org/log4j/changelog";
+ xsi:schemaLocation="http://logging.apache.org/log4j/changelog
https://logging.apache.org/log4j/changelog-0.1.3.xsd";
+ type="updated">
+ <description format="asciidoc">
+ Simplify BND configuration after upgrade from version 6.4.1 to 7.0.0.
Review Comment:
Please note that this is of type `changed`, not `updated`. I guess you play
this trick to get a patch release out. Let's not trick anyone, but be
transparent. (I don't have energy to argue about patch-vs-minor anymore.)
Please use `updated` only for, as its name implies and we agreed on, dependency
updates.
```suggestion
type="changed">
<description format="asciidoc">
Simplify BND configuration after upgrade from version `6.4.1` to `7.0.0`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
