vy commented on code in PR #2120:
URL: https://github.com/apache/logging-log4j2/pull/2120#discussion_r1434090267
##########
log4j-core/pom.xml:
##########
@@ -66,15 +66,16 @@
<!-- Remove `transitive` from optional dependencies -->
com.fasterxml.jackson.annotation;transitive=false,
com.lmax.disruptor;transitive=false,
- com.fasterxml.jackson.core;substitute="jackson-core";transitive=false,
-
com.fasterxml.jackson.databind;substitute="jackson-databind";transitive=false,
-
com.fasterxml.jackson.dataformat.xml;substitute="jackson-dataformat-xml";transitive=false,
-
com.fasterxml.jackson.dataformat.yaml;substitute="jackson-dataformat-yaml";transitive=false,
+ com.fasterxml.jackson.core;transitive=false,
+ com.fasterxml.jackson.databind;transitive=false,
+ com.fasterxml.jackson.dataformat.xml;transitive=false,
+ com.fasterxml.jackson.dataformat.yaml;transitive=false,
java.naming;transitive=false,
org.apache.commons.csv;transitive=false,
org.fusesource.jansi;transitive=false,
+ <!-- Newer versions have a module descriptor -->
+
com.conversantmedia.disruptor;substitute="disruptor";transitive=false;static=true,
Review Comment:
Got it. Jackson is still at version `2.16.0`, right? That is, no JPMS
descriptor. Shouldn't we be keeping `substitute` there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
