ppkarwasz commented on code in PR #2249:
URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467455327
##########
log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java:
##########
@@ -15,7 +15,7 @@
* limitations under the license.
*/
@Export
-@Version("2.21.1")
+@Version("2.22.0")
Review Comment:
You might have missed my proposal:
https://lists.apache.org/thread/tv3t11pwq54ch56qrj6odz9hngys1761
Rationale: it might be confusing to users to match the package version with
the artifact version. If they see "2.22.0", they might think `log4j-api` 2.22.0
is enough. So I would propose:
- for a micro bump, just increase the micro number (e.g. `2.21.1` ->
`2.21.2`). If users compiled their code against package number `2.21.7`, it
should still work with `log4j-api` 2.21.0 (module bug fixes),
- for a minor bump, align the version number with the version of
`log4j-api`. If the package is `2.21.1` we bump it to `2.23.0` in 2.x and
`3.0.0` in 3.x (unless we can guarantee that the changes in 2.x and 3.x are
synchronized).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
