jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468018836
########## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ########## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export -@Version("2.21.1") +@Version("2.22.0") Review Comment: If we use the module version as the package version, then we should also update the various packages marked as version `1.0.0`. And if `Foo.class.getPackage().getSpecificationVersion()` (and `getImplementationVersion()`) return the module version rather than the OSGi package version, that's just further confusion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org