ppkarwasz commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1579825873
########## src/site/antora/modules/ROOT/pages/manual/json-template-layout.adoc: ########## @@ -1085,7 +1085,7 @@ Resolves `logEvent.getMessage().getParameters()`. Regarding garbage footprint, `stringified` flag translates to `String.valueOf(value)`, hence mind not-`String`-typed values. Further, `logEvent.getMessage()` is expected to implement `ParameterVisitable` interface, -which is the case if `log4j2.enableThreadLocals` property set to true. +which is the case if `log4j2.enableThreadlocals` property set to true. Review Comment: The matching is not so fuzzy. For a given legacy property name (`log4j2.enable.threadlocals`), `PropertiesUtil` looks for: * a property of the same name, * a property with a normalized name (`LOG4J_ENABLE_THREADLOCALS` for environment variables, `log4j2.enableThreadlocals` for all other property sources), * a property that contains the same tokens (e.g. `org.apache.logging.log4j.enableThreadlocals`). The tokenizer is in `PropertySource.Util`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
