vy commented on code in PR #2517: URL: https://github.com/apache/logging-log4j2/pull/2517#discussion_r1580556072
########## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ########## Review Comment: Giving it a second thought, I think I pointed you in the wrong direction. _"Don't use `ThreadLocal`s"_ flag make totally no sense in the context of `ThreadContext`. Hence, I think we should not employ `ENABLE_THREADLOCALS` anywhere in the decision making here. Same goes for `IS_WEBAPP`. In short, unless `DISABLE_CONTEXT_MAP || DISABLE_THREAD_CONTEXT`, implementation should choose the most efficient map, regardless of `ENABLE_THREADLOCALS` and `IS_WEBAPP` settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
