rm5248 commented on code in PR #378:
URL: https://github.com/apache/logging-log4cxx/pull/378#discussion_r1582969318
##########
src/main/include/log4cxx/helpers/aprinitializer.h:
##########
@@ -44,7 +44,11 @@ class FileWatchdog;
class APRInitializer
{
public:
+#if LOG4CXX_ABI_VERSION <= 15
static log4cxx_time_t initialize();
+#else
+ static log4cxx_time_t getStartTime();
+#endif
Review Comment:
Instead of having a `#ifdef` here, would it make more sense to just have
both methods?
To keep ABI compatibility it's okay to add methods, we just can't remove old
ones unless we do an ABI bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
