fluffynuts commented on code in PR #157:
URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693003946
##########
src/log4net/Repository/Hierarchy/Hierarchy.cs:
##########
@@ -203,22 +203,22 @@ public Logger Root
{
get
{
- if (m_root is null)
+ if (rootLogger is null)
{
lock (this)
Review Comment:
i know this is the existing code, but `lock(this)` is potentially
problematic - something else could lock `this` from the outside; I'd recommend
adding a lock object and locking that; probably ok though - it's probably been
this way since the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
