michal-ciechan commented on code in PR #157:
URL: https://github.com/apache/logging-log4net/pull/157#discussion_r1693121907
##########
src/log4net/Repository/Hierarchy/Hierarchy.cs:
##########
@@ -252,12 +249,7 @@ public ILoggerFactory LoggerFactory
/// </remarks>
public override ILogger? Exists(string name)
{
- if (name is null)
- {
- throw new ArgumentNullException(nameof(name));
- }
-
- m_ht.TryGetValue(new LoggerKey(name), out object? o);
+ loggers.TryGetValue(new(name.EnsureNotNull()), out object? o);
Review Comment:
I would have kept `name.EnsureNotNull()` on its own line at the start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
