ppkarwasz commented on PR #2849: URL: https://github.com/apache/logging-log4j2/pull/2849#issuecomment-2309804667
> > The change should have no noticeable impact on the loading time of Log4j Core, while at the same time simplifies the system. > > **Reminder:** If the goal is simplification, [we can even replace all existing sort-on-add lines with a single sort-while-iterating](https://github.com/apache/logging-log4j2/pull/2454#discussion_r1661430727). I dropped a comment in there. Replacing the locks and the `ArrayList` with a concurrent set introduces only a couple of `µs` to the startup process, so should be negligible. I applied the suggested change in https://github.com/apache/logging-log4j2/pull/2849/commits/28b46de1d0b47bfdec1daf5c8e0ba205ba84f9e9. > I would have expected following properties (collected from the `rel/2.23.1` site) to not work anymore: > > * `log4j2.enable.direct.encoders` > > * `log4j2.jmx.notify.async` > > > Though they still do work. Would you mind explaining why, please? These are the correct pre-2.10 forms of these properties, that is why they work. I don't plan for this change to be so drastic as to disable configuration properties that were **documented** in previous Log4j Core versions. I only want to remove those that were not documented, but worked by some chance, e.g. `log4j2.jmx.notifyAsync`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
