ppkarwasz commented on code in PR #2849: URL: https://github.com/apache/logging-log4j2/pull/2849#discussion_r1731005808
########## src/changelog/.2.x.x/2849-remove-token-based-matching.xml: ########## @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="changed"> Review Comment: The `removed` change type is IMHO for changes that warrant a major version bump. This PR changes some Log4j internal optimizations and changes behavior (if users had typos in configuration properties, like a missing `2` in `log4j2`, these will no longer be recognized), but I don't see it as a "feature" that disappears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
