FreeAndNil commented on PR #199: URL: https://github.com/apache/logging-log4net/pull/199#issuecomment-2433548884
Hi @gdziadkiewicz, trying to answer some of your questions. > ### Testing > > It would be great to be able to run tests for log4net on all combinations of frameworks and OSes automatically (would you be interested in someone getting started work on it?). Yes, there is #106 and a github-actions branch from @rm5248 - I didn't find the time yet to take a closer look. > In the meantime it draws as important for me to test (not sure about expected results yet): > > * windows + net8 > * windows + net6 > * windows + net461 > * linux + net8 > * linux + net6 > * mac + net8 > * mac + net6 > * linux + mono > * mac + mono > * windows + mono I think we can skip net6 (support ends in 3 weeks) and mono on windows (I don't think many users will do this). > > ### Questions to answer before finalizing the change > > 1. Is WindowsIdentity Windows specific (name seems to suggest it)? Yes. https://github.com/dotnet/runtime/tree/main/src/libraries/System.Security.Principal.Windows/src > 2. How is `Environment.User` implemented on different platforms? Does it change? Is it expensive? Would caching make sense? It should work on all platforms, but it seems to give different results in web applications. See https://stackoverflow.com/questions/33665929/whats-the-difference-between-system-environment-username-and-user-identity-name > 3. Does and WindowsIdentity work on Mono on Win? If yes, how? Yes. Same as net471. https://github.com/mono/mono/blob/main/mcs/class/corlib/System.Security.Principal/WindowsIdentity.cs > 4. [RuntimeInformation.IsOSPlatform](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation.isosplatform?view=netframework-4.7.1) is supported from net471, would reformulating the #if around it to communicate that help in the future? Do you mean switching from net462 to net471 or adding a comment in the code? Caching of the username seems not to be necessary. I get around 500 ms for 10.000 calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
