FreeAndNil commented on PR #199: URL: https://github.com/apache/logging-log4net/pull/199#issuecomment-2437132902
> My plan was to find the answers alone, without using your time :D Thank you for the research! > > > Do you mean switching from net462 to net471 or adding a comment in the code? > > Current code guarding the code is `#if !NET462_OR_GREATER` which, combined with us targeting net462 and netstandard20, means we won't include the call in any classic .net framework, only netstandard20. That works , but the way matching the docs would to only exclude it in net462 (cause that's where it is missing). Right now it doesn't matter, but if we retarget to net472 or something in the future that call which could be used there to check the OS easily will be excluded. So changing the #if would be future-proofing. Good point, you can adjust this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
