rm5248 commented on code in PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#discussion_r2049170842
##########
src/main/include/log4cxx/private/aprserversocket.h:
##########
@@ -31,7 +31,7 @@ namespace helpers
class LOG4CXX_EXPORT APRServerSocket : public helpers::ServerSocket
{
public:
- APRServerSocket(int port);
+ APRServerSocket(int port, bool reuseAddress = true);
Review Comment:
This causes an ABI breakage, you need to add a new constructor that takes in
two parameters
##########
src/main/include/log4cxx/helpers/serversocket.h:
##########
@@ -57,7 +57,7 @@ class LOG4CXX_EXPORT ServerSocket
*/
void setSoTimeout(int timeout);
- static ServerSocketUniquePtr create(int port);
+ static ServerSocketUniquePtr create(int port, bool reuseAddress
= true);
Review Comment:
This causes an ABI breakage. You need to add a new method that takes in two
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
