swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2815290095
Please also change the .cpp files so building with `LOG4CXX_ABI_VER=16` works
```
diff --git a/src/main/cpp/aprserversocket.cpp
b/src/main/cpp/aprserversocket.cpp
index 538a3d2b..b7bd27f5 100644
--- a/src/main/cpp/aprserversocket.cpp
+++ b/src/main/cpp/aprserversocket.cpp
@@ -35,8 +35,10 @@ struct APRServerSocket::APRServerSocketPriv : public
ServerSocketPrivate {
apr_socket_t* socket;
};
+#if LOG4CXX_ABI_VERSION <= 15
APRServerSocket::APRServerSocket(int port) :
APRServerSocket(port, false) {}
+#endif
APRServerSocket::APRServerSocket(int port, bool reuseAddress) :
ServerSocket(std::make_unique<APRServerSocketPriv>()){
diff --git a/src/main/cpp/serversocket.cpp b/src/main/cpp/serversocket.cpp
index 705b9181..e696bd1c 100644
--- a/src/main/cpp/serversocket.cpp
+++ b/src/main/cpp/serversocket.cpp
@@ -51,9 +51,11 @@ void ServerSocket::setSoTimeout(int newVal)
m_priv->timeout = newVal;
}
+#if LOG4CXX_ABI_VERSION <= 15
ServerSocketUniquePtr ServerSocket::create(int port){
return std::make_unique<APRServerSocket>(port);
}
+#endif
ServerSocketUniquePtr ServerSocket::create(int port, bool reuseAddress){
return std::make_unique<APRServerSocket>(port, reuseAddress);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
