WorldRobertProject commented on issue #494: URL: https://github.com/apache/logging-log4cxx/issues/494#issuecomment-2814856038
@rm5248 For now, this issue has been resolved by the overlay port. Thank you so much. I realized that there is still an issue caused by character encoding. The character type for file names in LocationInfo is char. File names that contain non-ASCII characters are not correctly logged. We think the character type for file names should be logchar or another typedef type. That said, file names with non-ASCII characters are basically never used, so it will be an issue as long as only short file names are logged. (Directory names may contain non-ASCII chacacters.) The character type for function names being 'char' is maybe not an issue, but the current C++ standard allows function names to include non-ASCII characters. (while it is not common...) It might be better changed to logchar or another typedef type, too, but the severity may be low. @swebb2066 Sorry, we don't use Qt. Because conversion from Shift_JIS to UTF-8 typically goes through UTF-16, UTF-16 is more efficient than UTF-8. We need to integrate with C# in our custom appender, and C#'s char is UTF-16. This is another reason why we want to use wchar_t. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
