rm5248 commented on issue #494:
URL: 
https://github.com/apache/logging-log4cxx/issues/494#issuecomment-2814323969

   > It looks like this changed here: 
[4507748](https://github.com/apache/logging-log4cxx/commit/45077480eb6af9bb222c554cad7e2c02d1951fc6)
   > 
   > You should be able to work around this by setting `LOG4CXX_CHAR=wchar_t` 
when configuring, although I'm not sure how to configure that with vcpkg at the 
moment.
   
   It seems that the way to fix this is for you to use an overlay port in 
vcpkg, as we [should not use features to implement 
alternatives](https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-use-features-to-implement-alternatives).
  There are some directions on [installing locally modified 
dependencies](https://learn.microsoft.com/en-us/vcpkg/consume/install-locally-modified-package?pivots=shell-powershell)
 where you can set the `LOG4CXX_CHAR` option in the vcpkg port file.
   
   @swebb2066 I don't think there's much for us to do here, this seems like a 
rather specific to Japanese.  From the [wikipedia 
page](https://en.wikipedia.org/wiki/Shift_JIS) it sounds like Shift_JIS is not 
UTF-8 nor UTF-16, but a different 16-bit encoding entirely.  I think the best 
thing for us to do here would be to provide an example overlay file for vcpkg 
to let users set their encoding instead of trying to figure it out on our own.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to