norrisjeremy commented on PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#issuecomment-2978292816
> We should use `setFilter` instead of `withFilter`. > > I also noticed that **none** of our tests use the `LoggerConfig` builder and they call the deprecated `LoggerConfig#createLogger` method instead. Could you fix this? @ppkarwasz What is the justification for deprecating `withFilter()`? Nothing else in this builder class is configured with a setter, but rather they are all withers, so this seems to introduce an API inconsistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
