norrisjeremy commented on PR #3372: URL: https://github.com/apache/logging-log4j2/pull/3372#issuecomment-2980153817
Hi @ppkarwasz, Thank you for your detailed response. To answer your question about the impact: we deliberately run compiler warnings & deprecations set to errors for our internal apps, so that they immediately cause a compilation failure, in order for our team to notice and deal with API deprecations immediately and avoid having them pile up over time. So we immediately noticed the deprecation when a Dependabot PR for one of our internal apps failed to build yesterday. Upon seeing the deprecation warning, we first turned to the release notes for the new 2.25.0 release, but did not note any mention of the `withFilter()` method being deprecated. And then when trying to load up the latest Javadocs, noticed that they had not yet been published on the website. (And in fact updated Javadocs are still not published, as all the pages linked [here](https://logging.apache.org/log4j/2.x/javadoc.html) lead to 404 page not found errors...) This then led us to having to go dumpster diving through Github, to determine how to handle the deprecation, as well as why it had been occurred. On top of this, this is the second time in past year that this API method has been touched. In the 2.24.0 release, the original `withtFilter()` was marked as deprecated in lieu of the new `withFilter()` method (see #788). So all told, this is just frustrating: it results in lost time & productivity for what is amounting to whack-a-mole operation, chasing the whims of upstream library developers: deprecating and changing withers to setters in a Builder class just doesn't seem to offer tangible benefit to any existing users. Thanks, Jeremy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
