ppkarwasz commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182418054
########## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java: ########## Review Comment: > Disclosing legacy patterns in the binary footprint will make it impossible to deprecate the legacy support in the future. I'd appreciate it if you can update this class as follows: > (...) > 8. Bump the `@Version` in `package-info.java` to `2.26.0` So should we expose the class (and bump the version) or hide the class from the public API. I am slightly pending towards hiding the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
