ashr123 commented on code in PR #3789:
URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2182661068
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java:
##########
Review Comment:
@vy:
1. Java convention is to distinguish between date, time and date-time
entities, if I’ll call it `DatePattern` it may be a bit confusing, don’t you
think? And indeed it concerns itself only about what you called named-patterns
3. regarding point 3, don’t you prefer using
`InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` (which is constant)
directly instead of creating another constant in `DatePattern`? In addition,
the compiler gives me the following error:
> Cannot read value of field 'COMPAT' before the field's definition
As the constant field are initialized after the literals
5. regarding 5, the hole point is to use the built-in mechanism of mapping
`String` into an enum.. why should we iterate over the literals (and sort of
re-inventing the wheel)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
