vy commented on code in PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#discussion_r2191738856
########## log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/NamedPattern.java: ########## Review Comment: @ashr123, thanks so much for the prompt reaction. Please note that there are no full-time employed Log4j maintainers, we're just volunteers. Hence, don't late communication delays discourage you. Your contributions are very much appreciated. :muscle: :100: > Java’s convention is to distinguish between date, time and date-time entities, if I’ll call it `DatePattern` it may be a bit confusing, don’t you think? And indeed it concerns itself only about what you called named-patterns I agree, but we cannot change it for better without breaking compatibility. The converter is called _"date pattern"_ converter – sticking to a similar naming scheme will reduce the guess work and help with cognitive load while navigating sources. > Cannot read value of field 'COMPAT' before the field's definition Darn. Can you at least statically import `LEGACY_FORMATTERS_ENABLED` to save some screen real estate, please? > the whole point is to use the built-in mechanism of mapping String into an Enum.. why should we iterate over the literals (and sort of re-inventing the wheel)? Because catching an exception implies... something exceptional, something _bad_ has happened. Though this does not apply to us. (There is also the performance aspect of thrown exceptions, but it is of no subject here.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
