swebb2066 commented on PR #585:
URL: https://github.com/apache/logging-log4cxx/pull/585#issuecomment-3845157573
Please also update RollingFileAppender to use the new functionality:
```
$ git diff src/main/cpp/rollingfileappender.cpp
diff --git a/src/main/cpp/rollingfileappender.cpp
b/src/main/cpp/rollingfileappender.cpp
index 4112864c..a4f3afe0 100644
--- a/src/main/cpp/rollingfileappender.cpp
+++ b/src/main/cpp/rollingfileappender.cpp
@@ -120,7 +120,7 @@ void RollingFileAppender::setMaximumFileSize(size_t
maxFileSize)
void RollingFileAppender::setMaxFileSize(const LogString& value)
{
- setMaximumFileSize(OptionConverter::toFileSize(value,
long(getMaximumFileSize() + 1)));
+ setMaximumFileSize(OptionConverter::toFileSize64(value,
getMaximumFileSize() + 1));
}
LogString RollingFileAppender::makeFileNamePattern(const LogString&
datePattern)
```
Also update the documentation for the added functionality:
```
$ git diff src/main/include/log4cxx/rolling/sizebasedtriggeringpolicy.h
diff --git a/src/main/include/log4cxx/rolling/sizebasedtriggeringpolicy.h
b/src/main/include/log4cxx/rolling/sizebasedtriggeringpolicy.h
index f26effc5..be39dcf1 100644
--- a/src/main/include/log4cxx/rolling/sizebasedtriggeringpolicy.h
+++ b/src/main/include/log4cxx/rolling/sizebasedtriggeringpolicy.h
@@ -89,9 +89,9 @@ class LOG4CXX_EXPORT SizeBasedTriggeringPolicy : public
TriggeringPolicy
MaxFileSize | (\ref fileSize "1") | 10 MB |
\anchor fileSize (1) An integer in the range 0 - 2^63.
- You can specify the value with the suffixes "KB", "MB" or
"GB" so that the integer is
- interpreted being expressed respectively in kilobytes,
megabytes
- or gigabytes. For example, the value "10KB" will be
interpreted as 10240.
+ You can specify the value with the suffixes "KB", "MB",
"GB" or "TB" so that the integer is
+ interpreted being expressed respectively in kilobytes,
megabytes, gigabytes
+ or terabytes. For example, the value "10KB" will be
interpreted as 10240.
*/
void setOption(const LogString& option, const LogString&
value) override;
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
