rm5248 commented on code in PR #585:
URL: https://github.com/apache/logging-log4cxx/pull/585#discussion_r2739674528
##########
src/main/include/log4cxx/helpers/optionconverter.h:
##########
@@ -72,7 +72,16 @@ class LOG4CXX_EXPORT OptionConverter
converts the provided number respectively to kilobytes,
megabytes
and gigabytes. For example, the value "10KB" will be
interpreted as 10240.
*/
+ /**
+ * @deprecated Use toFileSize64 instead.
+ */
static long toFileSize(const LogString& value, long
defaultValue);
+
+ /**
+ * The numeric equivalent of \c value if it is not empty,
otherwise \c defaultValue.
+ * Supports 64-bit values for file sizes > 2GB.
+ */
+ static long long toFileSize64(const LogString& value, long long
defaultValue);
Review Comment:
@swebb2066 any thoughts on `long long` vs. `int64_t`? The latter is used in
a few parts of the API, but they should both be equivalent.
##########
src/main/include/log4cxx/helpers/optionconverter.h:
##########
@@ -72,7 +72,16 @@ class LOG4CXX_EXPORT OptionConverter
converts the provided number respectively to kilobytes,
megabytes
and gigabytes. For example, the value "10KB" will be
interpreted as 10240.
*/
+ /**
+ * @deprecated Use toFileSize64 instead.
Review Comment:
this should use the newer `[[deprecated]]` annotation like is used in other
places(example:
https://github.com/apache/logging-log4cxx/blob/28a443edaf226b37996bc653aed9b4d666785458/src/main/include/log4cxx/helpers/class.h#L37)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
