vy commented on code in PR #4098: URL: https://github.com/apache/logging-log4j2/pull/4098#discussion_r3264256197
########## log4j-api/src/main/java/org/apache/logging/log4j/util/internal/package-info.java: ########## Review Comment: > Adding `import org.apache.logging.log4j.util.internal.SerializationUtil` > to log4j-core created a cross-bundle OSGi `Import-Package` requirement > on an unexported package, breaking `log4j-osgi-test`. Mirror the > `core.util.internal.instant` package and ship a `package-info.java` > that exports `util.internal` with javadoc warning external users away. I don't think this is acceptable. You're making an internal package public. We need to come up with another way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
