SunWeb3Sec commented on code in PR #4098: URL: https://github.com/apache/logging-log4j2/pull/4098#discussion_r3310268668
########## log4j-api/src/main/java/org/apache/logging/log4j/util/internal/package-info.java: ########## Review Comment: Thanks for the pointer. I gave @ExportTo a try using the instant package as the model, but it only narrows the JPMS export — it does not change the OSGi Export-Package. That means util.internal would still end up exported to every bundle under OSGi. Reworking it to fit cleanly also started touching more than felt safe, including reverting the facade, re-routing callers, and enumerating consumer modules, with some risk of side effects. I’d rather not rush a change with that much churn, so I’ll leave it as-is for now / park this PR and revisit it once I find a cleaner approach. or maybe close first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
