jmestwa-coder commented on code in PR #682:
URL: https://github.com/apache/logging-log4cxx/pull/682#discussion_r3273829431
##########
src/main/cpp/syslogwriter.cpp:
##########
@@ -64,6 +64,16 @@ SyslogWriter::~SyslogWriter(){}
void SyslogWriter::write(const LogString& source)
{
+#if defined(UNIT_TEST)
Review Comment:
`UNIT_TEST` is defined in `syslogappendertestcase.cpp`, so this path is only
enabled for those tests.
The goal was to make the packet-size assertions deterministic without
depending on UDP/network behavior. If there’s a preferred way to structure this
kind of test in log4cxx, I’m happy to adjust it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
