jmestwa-coder commented on code in PR #682:
URL: https://github.com/apache/logging-log4cxx/pull/682#discussion_r3298961009
##########
src/main/cpp/syslogwriter.cpp:
##########
@@ -64,6 +64,16 @@ SyslogWriter::~SyslogWriter(){}
void SyslogWriter::write(const LogString& source)
{
+#if defined(UNIT_TEST)
Review Comment:
Thanks for the suggestion .
I reworked the patch to move the splitting logic into a dedicated helper
that `SyslogAppender` calls directly, removed the `UNIT_TEST` interception
path, and updated the tests to validate the helper behavior directly instead of
capturing network writes.
If there’s still a simpler structure you’d prefer here, I’m happy to adjust
it further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
