jmestwa-coder commented on PR #698: URL: https://github.com/apache/logging-log4cxx/pull/698#issuecomment-4601446223
My understanding was that `DatagramPacket` exposes offset-aware constructors and stores both an offset and length, which led me to interpret the offset as part of the packet contract rather than unused state. The tests I added demonstrate that the current implementation ignores the stored offset during send/receive and does not update the packet length after receive. That said, if the intended design is that offsets are not meant to influence socket operations, or if receive paths are effectively unused in log4cxx, I'm happy to narrow the change or revisit the approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
