jmestwa-coder commented on PR #698: URL: https://github.com/apache/logging-log4cxx/pull/698#issuecomment-4841080062
Agreed, #696 covers this. The size_t switch there makes the negative offset/length checks in this PR redundant, and it conflicts in datagrampacket.cpp for the same reason. The only remaining piece is the socket-side offset handling, which is the part rm5248 wasn't sold on anyway, so it's not worth rebasing on its own. Closing this one and keeping #696. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
