ramanathan1504 commented on PR #4160: URL: https://github.com/apache/logging-log4j2/pull/4160#issuecomment-4824964467
Hi @ppkarwasz, I have tested these changes locally and verified that the behavior works as expected. I do have a quick question regarding some of the inline comments (for example, // 1. A genuine absolute URI...) inside the utility functions. Since @vy has previously suggested in other pull requests to avoid inline comments when the code is self-documenting, should we remove or simplify them here, or is it preferred to keep them? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
