vy commented on code in PR #4160: URL: https://github.com/apache/logging-log4j2/pull/4160#discussion_r3489782083
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/NetUtilsTest.java: ########## Review Comment: @ppkarwasz, shall we exercise more patterns taking following combinations into account? - `//a/b/c` — Is this a path, or a URI where the authority component is `a`? - `///a/b/c` — triple-slash - `file:/C:/a/b` — single-slash & drive letter - `http://example.com//a/b` - `http://example.com///a/b` - `http://example.com\c\a\b` - `http://example.com/c\a\b` - `http://example.com/c:\a\b` - `http://example.com//c:\a\b` - `http://example.com///c:\a\b` These are inspirational, neither exhaustive, nor required. Some might even be invalid and throwing — maybe better to add a negative test case for those instead of discarding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
