kamilkrzywanski opened a new pull request, #4184:
URL: https://github.com/apache/logging-log4j2/pull/4184
Fixes #4105.
`AnsiEscape` was missing `italic` (SGR 3) and had `underline` mapped to 3
instead of 4. After the Jansi removal, that made `italic` warn as invalid and
`underline` render as italic.
## Changes
- Add `ITALIC("3")` and correct `UNDERLINE` to `"4"`
- Document `italic` in the pattern layout style keywords
- Add regression tests with hard-coded SGR sequences
- Changelog entry
## Checklist
* Base your changes on `2.x` branch if you are targeting Log4j 2; use `main`
otherwise
* `./mvnw verify` succeeds ([the build
instructions](https://logging.apache.org/log4j/2.x/development.html#building))
* Non-trivial changes contain an entry file in the `src/changelog/.2.x.x`
directory
* Tests are provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
