ramanathan1504 commented on code in PR #4184:
URL: https://github.com/apache/logging-log4j2/pull/4184#discussion_r3694534615
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/JAnsiTextRendererTest.java:
##########
@@ -39,6 +39,11 @@ public static Stream<Arguments> testRendering() {
"",
"@|white key|@ = @|cyan,bold some value|@",
"\u001b[37mkey\u001b[m = \u001b[36;1msome
value\u001b[m"),
+ // GitHub issue #4105: italic = SGR 3, underline = SGR 4
+ Arguments.of(
+ "",
+ "@|italic italic text|@ and @|underline underlined
text|@",
+ "\u001b[3mitalic text\u001b[m and \u001b[4munderlined
text\u001b[m"),
// Return broken escapes as is
Review Comment:
here also remove comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
