DragonFSKY commented on code in PR #4199:
URL: https://github.com/apache/logging-log4j2/pull/4199#discussion_r3700946299
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java:
##########
@@ -616,12 +628,6 @@ private Configuration getConfiguration(
final ConfigurationSource source =
ConfigurationSource.fromResource(configName, loader);
if (source != null) {
- if (!factory.isActive()) {
Review Comment:
Thanks, this direction makes sense. I have updated the PR accordingly:
supported types remain discoverable, inactive factories return `null`, and
aggregate lookup does not invoke them to create configurations, while
preserving the existing file-specific diagnostic and fallback behavior. Please
let me know if anything else needs adjusting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
