rm5248 commented on code in PR #786:
URL: https://github.com/apache/logging-log4cxx/pull/786#discussion_r4324558017
##########
src/main/include/log4cxx/logmanager.h:
##########
@@ -75,16 +75,6 @@ class LOG4CXX_EXPORT LogManager
*/
static LoggerPtr getRootLogger();
- /**
- Retrieve the \c name Logger instance from the
- {@link spi::LoggerRepository LoggerRepository}
- using the default factory to create it if required.
-
- Calls {@link spi::LoggerRepository::ensureIsConfigured
ensureIsConfigured} passing {@link DefaultConfigurator::configure} to ensure
- the repository is configured.
- */
- static LoggerPtr getLogger(const std::string& name);
Review Comment:
I know that I've written code before that uses `LogManager::getLogger()`
since it is equivalent to `Logger::getLogger()` - adding an explicit entry to
the changelog stating the removal(and how to fix) would be good here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
