swebb2066 commented on code in PR #786:
URL: https://github.com/apache/logging-log4cxx/pull/786#discussion_r4332086727
##########
src/main/include/log4cxx/logmanager.h:
##########
@@ -75,16 +75,6 @@ class LOG4CXX_EXPORT LogManager
*/
static LoggerPtr getRootLogger();
- /**
- Retrieve the \c name Logger instance from the
- {@link spi::LoggerRepository LoggerRepository}
- using the default factory to create it if required.
-
- Calls {@link spi::LoggerRepository::ensureIsConfigured
ensureIsConfigured} passing {@link DefaultConfigurator::configure} to ensure
- the repository is configured.
- */
- static LoggerPtr getLogger(const std::string& name);
Review Comment:
> I've written code before that uses LogManager::getLogger()
That code will continue to compile without any change. The compiler with
silently add the default value for `spi::LoggerFactoryPtr` and call the two
parameter version of LogManager::getLogger().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
