ramanathan1504 commented on PR #4364: URL: https://github.com/apache/logging-log4j2/pull/4364#issuecomment-6298149813
Masking a copy of `jndiProperties` leaves the `InitialContext` environment untouched, and both new test classes fail without the fix. The `jndiProperties != null` check in both `JmsManager.java` files has no test, so can we add a `null` case? The two new test classes can also use `org.junit.jupiter.api.Test` instead of JUnit 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
