ramanathan1504 commented on PR #4400: URL: https://github.com/apache/logging-log4j2/pull/4400#issuecomment-6300434108
The `floorDiv` and `floorMod` changes match `java.time`, and the new tests fail on `2.x` without them. The `toEpochMinutes` change in `InstantPatternDynamicFormatter` has no test, because each test case builds a new formatter and the cached minute is never reused. Can we add a test that formats `30 s` and then `-30 s` with one formatter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
