ramanathan1504 commented on code in PR #4400: URL: https://github.com/apache/logging-log4j2/pull/4400#discussion_r4336790639
########## src/changelog/.2.x.x/4399_negative_epoch_instants.xml: ########## @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4399" link="https://github.com/apache/logging-log4j2/issues/4399"/> + <issue id="4400" link="https://github.com/apache/logging-log4j2/pull/4400"/> + <description format="asciidoc"> + Fix `MutableInstant.initFromEpochMilli()` and the date pattern formatter producing a negative nano of second and wrong seconds for instants before the epoch. Review Comment: ```suggestion Fix `%d` printing wrong seconds for instants before the epoch. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
