vrahane commented on code in PR #3365: URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1956624105
########## sys/log/full/src/log_shell.c: ########## @@ -39,7 +39,7 @@ #include "tinycbor/compilersupport_p.h" #include "log_cbor_reader/log_cbor_reader.h" -void log_console_print_hdr(const struct log_entry_hdr *hdr); +void log_console_print_hdr(struct log_entry_hdr *hdr); Review Comment: That was an oversight probably but the const's were removed mainly because on our MCU we were seeing lower performance because the flash is external, not particularly with this code but in general. So, trying to reduce const usage wherever possible. Will change this back if you think its an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
