vrahane commented on code in PR #3365:
URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1956626636
##########
sys/log/full/src/log_shell.c:
##########
@@ -172,11 +174,18 @@ shell_log_dump_cmd(int argc, char **argv)
bool clear_log;
bool reverse = false;
bool dump_logs = true;
+ bool dump_bmarks = false;
+ uint32_t bmarks_size = 0;
+ struct log_fcb_bmark *bmarks = NULL;
struct walk_arg arg = {};
int i;
int rc;
clear_log = false;
+ (void)dump_bmarks;
+ (void)bmarks;
+ (void)bmarks_size;
Review Comment:
When bookmarks were disabled, I was getting an error while building, so I
added them. May not be the case anymore, let me double check on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
