vrahane commented on code in PR #3400:
URL: https://github.com/apache/mynewt-core/pull/3400#discussion_r2076162700
##########
sys/log/full/syscfg.yml:
##########
@@ -196,6 +202,10 @@ syscfg.defs:
restrictions:
- LOG_FCB_BOOKMARKS
- LOG_FCB
+ LOG_MAX_TRAILER_LEN:
+ description: >
+ Maximum length of trailer that can be appended to a log entry
+ value: "LF_MAX_ALIGN * 3"
Review Comment:
If the max alignment changes, the max trailer length is going to get
affected because alignment plays a big role in fitting the trailer, the
implementation of a trailer can be a TLV, a reverse TLV or static data but in
order for it to be read successfully from the end, alignment matters. I would
prefer to keep it this way if you don't feel strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
