vrahane commented on code in PR #3400: URL: https://github.com/apache/mynewt-core/pull/3400#discussion_r2076192178
########## sys/log/full/include/log/log.h: ########## @@ -531,11 +660,10 @@ int log_read_hdr(struct log *log, const void *dptr, struct log_entry_hdr *hdr); * @brief Reads the header length * * @param hdr Ptr to the header - * + * * @return Length of the header */ -uint16_t -log_hdr_len(const struct log_entry_hdr *hdr); +uint16_t log_hdr_len(const struct log_entry_hdr *hdr); Review Comment: The other changes namely adding the name of the variable for the prototypes: Example: https://github.com/apache/mynewt-core/pull/3400/files#diff-3fc9ab99b4a74c4fe2a0c49448e087a70997d395c5c16f99ce6fb1d923b72e4cR164 was actually requested by @kasjer here: https://github.com/apache/mynewt-core/pull/3168#discussion_r1642737620 I can remove the changes. As mentioned in the comment even I agree, keeping code consistent is better. Clean up should be done as a separate task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
