andrzej-kaczmarek commented on code in PR #3400:
URL: https://github.com/apache/mynewt-core/pull/3400#discussion_r2079591435
##########
sys/log/full/src/log.c:
##########
@@ -320,21 +324,41 @@ log_read_hdr_walk(struct log *log, struct log_offset
*log_offset, const void *dp
}
}
+ if (arg->hdr->ue_flags & LOG_FLAGS_TRAILER_SUPPORT && log->l_th) {
+#if MYNEWT_VAL(LOG_FLAGS_TRAILER_SUPPORT)
+ if (log->l_th->log_process_trailer) {
Review Comment:
I don't really understand what you are trying to do here.
If you call `log_walk` to read the log there should be a way for the
application to get the trailer data for each entry. This can be either by a
callback which `log_walk` should call for each entry or (I think preferably)
there should be an API that application can use to read that trailer data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
