vrahane commented on code in PR #3400:
URL: https://github.com/apache/mynewt-core/pull/3400#discussion_r2082133081
##########
sys/log/full/src/log.c:
##########
@@ -692,7 +679,9 @@ log_append_prepare(struct log *log, uint8_t module, uint8_t
level,
#endif
#if MYNEWT_VAL(LOG_FLAGS_TRAILER_SUPPORT)
- ue->ue_flags |= LOG_FLAGS_TRAILER_SUPPORT;
+ if (log->l_th) {
+ ue->ue_flags |= LOG_FLAGS_TRAILER_SUPPORT;
Review Comment:
If the application has registered trailer callbacks for that particular log,
that means the application knows how to handle the trailer data. I really don't
get your point. Please provide an alternate approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
