[
https://issues.apache.org/jira/browse/MYNEWT-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020272#comment-16020272
]
Wanda Chiu commented on MYNEWT-649:
-----------------------------------
Need some clarifications:
1) Valid variables for newt target set are: app, bsp, loader, build_profile,
cflags, lflags, aflags, syscfg. Are there other variables that *newt target
set* can set?
2) In regard to making sure that the "newt vals" command also covers this set
of valid target variables, I want to discuss the desire behavior before adding
a bunch of code that might not be needed. Currently the *newt vals* command
shows values for the following variables: *api, app, bsp, build_profile,
compiler, lib, sdk, target*, and does not show values for *syscfg, loader,
aflags, cflags, lflags*. I am not sure whether we need to or we can include
values for all these variables. Here are the reasons:
* syscfg - user can use newt target config show <target-name> to see all the
values. Do we need to show with *newt vals*?
* loader - There isn't a way to desginate that an app can be either an app or a
loader. All apps have pkg.type=app. To designate that an app can be either a
loader or an app, we will probably need to add another field such as
pkg.loader=true
* aflags, cflags, and lflags - I am not sure how useful it would be to print
these values out? I guess it could be useful to print out the values for each
compiler so the user will know if they need to add more aflags, cflags, and
lflags for their target. If we decide to print out the values, I am thinking:
** For aflags and lflags: We would printout the flags for each compiler.
** For cflags: We would printout the flags used for the each build profile
:base, default, optimized, and debug and for each compiler.
> "newt target set" allows random variable to be set; should allow only valid
> variable settings.
> ----------------------------------------------------------------------------------------------
>
> Key: MYNEWT-649
> URL: https://issues.apache.org/jira/browse/MYNEWT-649
> Project: Mynewt
> Issue Type: Bug
> Reporter: Aditi Hilbert
> Assignee: Wanda Chiu
> Fix For: v1_1_0_rel
>
>
> The "newt target set" command should have a check for allowed settings.
> For example, I can set the variable "bogus" with a value and target.bogus
> will be added to the target.yml file. Do we have a list of all the valid
> variables so we can add the validation to the command? What I have listed as
> valid variables in the `newt target set" command documentation are: app, bsp,
> loader, build_profile, cflags, aflags, lflags, syscfg.
> We should make sure the "newt vals" command also covers this set of valid
> target variables to make things consistent.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
