[
https://issues.apache.org/jira/browse/MYNEWT-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025702#comment-16025702
]
Wanda Chiu commented on MYNEWT-649:
-----------------------------------
Discuss with Aditi and decided newt vals command does not need to support
variables: syscfg, loader, aflags, cflags, lflags.
PR to validate the variables is:
https://github.com/apache/incubator-mynewt-newt/pull/65.
> "newt target set" allows random variable to be set; should allow only valid
> variable settings.
> ----------------------------------------------------------------------------------------------
>
> Key: MYNEWT-649
> URL: https://issues.apache.org/jira/browse/MYNEWT-649
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Reporter: Aditi Hilbert
> Assignee: Wanda Chiu
> Fix For: v1_1_0_rel
>
>
> The "newt target set" command should have a check for allowed settings.
> For example, I can set the variable "bogus" with a value and target.bogus
> will be added to the target.yml file. Do we have a list of all the valid
> variables so we can add the validation to the command? What I have listed as
> valid variables in the `newt target set" command documentation are: app, bsp,
> loader, build_profile, cflags, aflags, lflags, syscfg.
> We should make sure the "newt vals" command also covers this set of valid
> target variables to make things consistent.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
