wonook commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r265403735
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/NemoPipelineResult.java
##########
@@ -24,17 +24,28 @@
import org.joda.time.Duration;
import java.io.IOException;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
/**
* Beam result.
*/
public final class NemoPipelineResult extends ClientEndpoint implements
PipelineResult {
+ private final CountDownLatch jobDone;
/**
* Default constructor.
*/
public NemoPipelineResult() {
super(new BeamStateTranslator());
+ jobDone = new CountDownLatch(1);
Review comment:
I think that's just a matter of style: whether you feel more comfortable
with dealing with the latch yourself or with simply calling the method. What do
you think is the advantage over the current implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
